Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in header/footer tags for local header/footer #86

Closed
khawkins98 opened this issue Apr 24, 2017 · 2 comments
Closed

Add in header/footer tags for local header/footer #86

khawkins98 opened this issue Apr 24, 2017 · 2 comments
Milestone
1.2

Comments

@khawkins98
Copy link
Contributor

khawkins98 commented Apr 24, 2017 •
edited
Loading

As the HTML spec allows for multiple <header> and <footer> tags, we should use these elements for the local header and footer (current we just have them on the global EBI header/footer).

h/t to @pwalter-ebi for flagging this.
khawkins98 added a commit that referenced this issue Apr 24, 2017
@khawkins98
use header/footer in local content; for #86
b0418ce
@khawkins98
Copy link
Contributor Author

The updated page template: http://wwwdev.ebi.ac.uk/web_guidelines/EBI-Framework/v1.2/

khawkins98 added a commit that referenced this issue Apr 24, 2017
@khawkins98
Make masthead to be a non-div element (#86)
f8f0107
khawkins98 added a commit to ebiwd/EBI-Pattern-library that referenced this issue Apr 24, 2017
@khawkins98
Change header/footer element
2f58170 
for ebiwd/EBI-Framework#86
@khawkins98
Copy link
Contributor Author

Have also update the migration guide #85

nb: it doesn't particularly matter for the core look if these elements are used, though down the line we may want to adopt a more rigid stance...

@khawkins98 khawkins98 added this to the 1.2 milestone Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@khawkins98