Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSITION_INDEPENDENT_CODE ON for static compilations #317

Closed
sanguinariojoe opened this issue Jul 14, 2023 · 2 comments
Closed

POSITION_INDEPENDENT_CODE ON for static compilations #317

sanguinariojoe opened this issue Jul 14, 2023 · 2 comments
Labels

Comments

@sanguinariojoe
Copy link

You really want to add that option here. Otherwise static linking inside dynamic libraries would be impossible (like it is usually the case when making Python wheels)

@ebiggers
Copy link
Owner

You can already set -DCMAKE_POSITION_INDEPENDENT_CODE=1 when running cmake, if you want to. Is there a strong reason you want libdeflate to force it on for the static library, overriding the cmake default behavior?

@sanguinariojoe
Copy link
Author

Hey! Sorry, I missed this reply. Luckily @cary-ilm drawn my attention on this.

That option seems to work just fine.

https://github.com/sanguinariojoe/openexr/actions/runs/5701914625

I actually did not know you can add such an option to CMake... My bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants