From c21e4794bef9d42b1fc5d60ceb1aea12f76c0165 Mon Sep 17 00:00:00 2001 From: Easwar Swaminathan Date: Thu, 25 Jun 2020 12:27:33 -0700 Subject: [PATCH] Review comments #1. --- credentials/tls/certprovider/meshca/go.mod | 2 +- credentials/tls/certprovider/meshca/go.sum | 9 ++++++--- credentials/tls/certprovider/meshca/meshca.go | 3 +++ 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/credentials/tls/certprovider/meshca/go.mod b/credentials/tls/certprovider/meshca/go.mod index c012b62cce24..a7d39c9669ae 100644 --- a/credentials/tls/certprovider/meshca/go.mod +++ b/credentials/tls/certprovider/meshca/go.mod @@ -6,5 +6,5 @@ require ( github.com/envoyproxy/go-control-plane v0.9.5-0.20200326174812-e8bd2869ff56 github.com/golang/protobuf v1.4.2 google.golang.org/grpc v1.31.0-dev.0.20200616205733-dfc058c6d9dd - istio.io/istio v0.0.0-20200624211210-fba43d664ca1 + istio.io/istio v0.0.0-20200625184358-746a2b4c58c7 ) diff --git a/credentials/tls/certprovider/meshca/go.sum b/credentials/tls/certprovider/meshca/go.sum index 06dd019c6a6c..58da3fcb91b0 100644 --- a/credentials/tls/certprovider/meshca/go.sum +++ b/credentials/tls/certprovider/meshca/go.sum @@ -313,6 +313,7 @@ github.com/google/cel-spec v0.3.0/go.mod h1:MjQm800JAGhOZXI7vatnVpmIaFTR6L8FHcKk github.com/google/go-cmp v0.2.0/go.mod h1:oXzfMopK8JAjlY9xF4vHSVASa0yLyX7SntLO5aqRK0M= github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU= github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU= +github.com/google/go-cmp v0.4.0 h1:xsAVV57WRhGj6kEIi8ReJzQlHHqcBYCElAvkovg3B/4= github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE= github.com/google/gofuzz v0.0.0-20161122191042-44d81051d367/go.mod h1:HP5RmnzzSNb993RKQDq4+1A4ia9nllfqcQFTQJedwGI= github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg= @@ -790,6 +791,7 @@ golang.org/x/sys v0.0.0-20191008105621-543471e840be/go.mod h1:h1NjWce9XRLGQEsW7w golang.org/x/sys v0.0.0-20191022100944-742c48ecaeb7/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20191105231009-c1f44814a5cd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20191128015809-6d18c012aee9/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20200116001909-b77594299b42 h1:vEOn+mP2zCOVzKckCZy6YsCtDblrpj/w7B9nxGNELpg= golang.org/x/sys v0.0.0-20200116001909-b77594299b42/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.0.0-20160726164857-2910a502d2bf/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= @@ -833,6 +835,7 @@ golang.org/x/tools v0.0.0-20191125144606-a911d9008d1f/go.mod h1:b+2E5dAYhXwXZwtn golang.org/x/tools v0.0.0-20191216173652-a0e659d51361/go.mod h1:TB2adYChydJhpapKDTa4BR/hXlZSLoq2Wpct/0txZ28= golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= +golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4= golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= gomodules.xyz/jsonpatch/v2 v2.0.1/go.mod h1:IhYNNY4jnS53ZnfE4PAmpKtDpTCj1JFXc+3mwe7XcUU= gonum.org/v1/gonum v0.0.0-20190331200053-3d26580ed485/go.mod h1:2ltnJ7xHfj0zHS40VVPYEAAMTa3ZGguvHGBSJeRWqE0= @@ -930,11 +933,11 @@ honnef.co/go/tools v0.0.0-20190418001031-e561f6794a2a/go.mod h1:rf3lG4BRIbNafJWh honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4= honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg= istio.io/api v0.0.0-20190515205759-982e5c3888c6/go.mod h1:hhLFQmpHia8zgaM37vb2ml9iS5NfNfqZGRt1pS9aVEo= -istio.io/api v0.0.0-20200624012953-2e72df5eadd7/go.mod h1:uXD10AwGZkxIrVKTntYm2uyFWQQfNzhAGkIxLfRNocs= +istio.io/api v0.0.0-20200625150749-add85bd6bfe8/go.mod h1:uXD10AwGZkxIrVKTntYm2uyFWQQfNzhAGkIxLfRNocs= istio.io/gogo-genproto v0.0.0-20190930162913-45029607206a/go.mod h1:OzpAts7jljZceG4Vqi5/zXy/pOg1b209T3jb7Nv5wIs= istio.io/gogo-genproto v0.0.0-20200422223746-8166b73efbae/go.mod h1:OzpAts7jljZceG4Vqi5/zXy/pOg1b209T3jb7Nv5wIs= -istio.io/istio v0.0.0-20200624211210-fba43d664ca1 h1:T3oT5a/xSb5YhOO6eVn3+v3kPPBUrfs/7Hdn5r2sMX0= -istio.io/istio v0.0.0-20200624211210-fba43d664ca1/go.mod h1:3G3H25rKgMZ09PWxhleji4GiN240hErZ6Mlr3SGKtqU= +istio.io/istio v0.0.0-20200625184358-746a2b4c58c7 h1:F5hLp7Ht+Pxkm7eQNfQsCO1m52egCIZDcIng5R8YMrk= +istio.io/istio v0.0.0-20200625184358-746a2b4c58c7/go.mod h1:8i1X8soyIXtPrs4If+LK+tT65dio5/VV7iEWsI8L94s= istio.io/pkg v0.0.0-20200504224939-261164cc57da/go.mod h1:EwvmercDF5DLCg5qUQlkM40xHwCxGoY1H/2LhI1p2YU= k8s.io/api v0.0.0-20190918155943-95b840bb6a1f/go.mod h1:uWuOHnjmNrtQomJrvEBg0c0HRNyQ+8KTEERVsK0PW48= k8s.io/api v0.17.0/go.mod h1:npsyOePkeP0CPwyGfXDHxvypiYMJxBWAMpQxCaJ4ZxI= diff --git a/credentials/tls/certprovider/meshca/meshca.go b/credentials/tls/certprovider/meshca/meshca.go index 4fde6ffff0fa..dff9917e9ca1 100644 --- a/credentials/tls/certprovider/meshca/meshca.go +++ b/credentials/tls/certprovider/meshca/meshca.go @@ -16,6 +16,9 @@ * */ +// Package meshca implements a certificate provider which gets certificates signed by the MeshCa. +// +// TODO(easwars): Implement all required functionality. This is only skeleton code for now. package meshca import (