Wouldn't ‎DiscoveryDataBase::update second parameter (std::string topic_name) be more appropriate to use const reference?

[chunyisong]

Is there an already existing issue for this?

• I have searched the existing issues

Expected behavior

bool update(CacheChange_t* change, const std::string& topic_name);

Current behavior

bool update(CacheChange_t* change, std::string topic_name);

Steps to reproduce

bool update(CacheChange_t* change, std::string topic_name);

Fast DDS version/commit

v3.0.0

Platform/Architecture

Ubuntu Focal 20.04 amd64, Windows 10 Visual Studio 2019

Transport layer

Default configuration, UDPv4 & SHM, TCPv4, Shared Memory Transport (SHM)

Additional context

No response

XML configuration file

No response

Relevant log output

No response

Network traffic capture

No response

[JesusPoderoso]

Hi @chunyisong, thanks for your report.
I've opened a PR with the fix

• [21512] Set string arguments as const references #5179