-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker image #789
Comments
docker pump image |
|
Here I wrote a minimal example based on the Alpine image and an external JSON config file:
|
@adundovi I'd like the Docker image to be something officially maintained by the pump.io project - that means in some "official" namespace on Docker Hub and maintained in-tree, in sync with the rest of the codebase. If you're willing to maintain this long-term as a member of the project I'd be thrilled if you submitted a PR so that we can iterate on it and get that going. |
@strugee Well, I would like to contribute with that, but I am still fighting with different kind of "500 Internal Server Error" issues and there is no sense to submit anything if the stuff is not working. To add, I am not skillful with nodejs, which is making things harder to debug, thus I do not know if the bugs lie in my particular setup or in the pump.io code. If I will have the basic feature set working I will certainly polish and publish the docker code. |
@adundovi nonsense! PRs are a great way to get feedback on work-in-progress implementations. I regularly submit half-baked PRs to get early feedback on stuff :) If you send a PR I can try to reproduce your 500 errors locally and try and find where the problem is. Just prefix the title with |
@adundovi are you still interested in doing this? |
@adundovi probably this one? I'm not familiar with Docker so I dunno if that'll make things difficult - if so we can create a separate repo. But I think we should aim for this one if possible |
will this work?
https://github.com/niktrix/docker-pump.io
…On Mon, Mar 27, 2017 at 10:58 AM, Alex Jordan ***@***.***> wrote:
@adundovi <https://github.com/adundovi> probably this one? I'm not
familiar with Docker so I dunno if that'll make things difficult - if so we
can create a separate repo. But I think we should aim for this one if
possible
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#789 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABM9ZqdQjBYf99rRWgtaszqikKyLFZ2Eks5rp0jvgaJpZM4A7r7l>
.
--
Nitin Gurbani
http://niktrix.in
|
@Niktrix that Dockerfile seems really old... it's installing MongoDB from a third-party repo (which is unnecessary), it doesn't allow configuration, and it would be nice to base it on the Alpine image, so the image is smaller |
@strugee we dont have bandwidth to do so, thanks |
Is there a docker image for the raspberry pi (3)? |
@Serkan-devel you should feel free to build one yourself using the Dockerfile in this repository, but we are not officially distributing Docker images yet due to #1418. |
We need a docker.io image.
The text was updated successfully, but these errors were encountered: