You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, on the core / plugins, we got a lot of rendering HTML tags functions that doesn't accept any custom text to be rendered to be displayed, like for instance the Email, Print and Social buttons on the news plugin, and a lot more...
For instance, it's a nightmare to render these buttons with custom icons + text:
My question is can we please have at least the optiion to customize the text to be rendered by these functions, at template level?
Right now, to do that, we have to copy all the rendering shortcode to the theme just because of changing a single line....
Basically it forces almost copy 75% of the HTML shortcodes rendering code to the theme...
The way i see it, it can be donne two ways:
Via a {SETIMAGE} style shortcode before the buttons shortcode. But with functions that renders multiple buttons, like the Social buttons in the news plugin, it would be a little ankward...
Via a parameter sent to the shortcode itself, ie: text=whatever....
So im asking your options. Should it be donne? And if so, how?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
How rendering HTML should work?
Right now, on the core / plugins, we got a lot of rendering HTML tags functions that doesn't accept any custom text to be rendered to be displayed, like for instance the Email, Print and Social buttons on the news plugin, and a lot more...
![Buttons with icons](https://private-user-images.githubusercontent.com/17130530/405649808-31cb77bc-36b0-4f33-b450-b32169b97119.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTUzMzcsIm5iZiI6MTczOTU5NTAzNywicGF0aCI6Ii8xNzEzMDUzMC80MDU2NDk4MDgtMzFjYjc3YmMtMzZiMC00ZjMzLWI0NTAtYjMyMTY5Yjk3MTE5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA0NTAzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE4YWUzY2E3Yjk1M2I0YjYxM2QyNWIwNmRjZTg3ZmVkNDhmM2ZmNjdhODRlZGRhNjExYzZmNzIyYTk0OWZlZDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.m9a_cJNHpEYRkVfM1G4a4xFJ03IUqjmiRyyrt2S5e9A)
For instance, it's a nightmare to render these buttons with custom icons + text:
My question is can we please have at least the optiion to customize the text to be rendered by these functions, at template level?
Right now, to do that, we have to copy all the rendering shortcode to the theme just because of changing a single line....
Basically it forces almost copy 75% of the HTML shortcodes rendering code to the theme...
The way i see it, it can be donne two ways:
{SETIMAGE}
style shortcode before the buttons shortcode. But with functions that renders multiple buttons, like the Social buttons in the news plugin, it would be a little ankward...text=whatever
....So im asking your options. Should it be donne? And if so, how?
Just my two cents.
Thanks
Beta Was this translation helpful? Give feedback.
All reactions