How add wrappers to shortcodes with different parms? #5380
Replies: 3 comments 7 replies
-
|
maybe a dumb answer/question (from me) ( do understand what the goal seems) but is it not hierarchy? topic views is a shortcode to be actived on entry of page (url) same for replies. the simple one uses your naming striphtml (call it function) then open page > page affected I hope it makes sence what im trying to say ( at least that how i would interpret what i see). |
Beta Was this translation helpful? Give feedback.
-
|
@tgtje The SPT_STRIPHTML is a custom theme shortcode of mine. I used that shortcode here just as a example. |
Beta Was this translation helpful? Give feedback.
-
|
News templates use parameters new way (with :)
Wrappers are for adding HTML code depending if the shortcode is empty or not. Can it be {SPT_STRIPHTML=TOPIC_VIEWS} ever empty or is the value always a number (zero is a number too)? Your goal should be solved by adding parameters to the shortcode itself not in the template. This part should be part of shortcode: |
Beta Was this translation helpful? Give feedback.
-
Indeed, but if i have a shortcode with paramenters that i WANT to format differently if they have output, i can't. See my point?
No, this shortcode ALWAYS outputs something different from null, on output 0 is considered a string, so it outputs....
Sorry, but i dissagree... For me, there should ever never be any HTML harcoded inside the PHP code. It's bad programming and very annoying to make changes. If we have templates to make the HTML, why don't we use it? HTML is for designers, PHP is for coders, as clean and simple as that.... That's how i see it, and it's one of my major battles with e107.... |
Beta Was this translation helpful? Give feedback.
-
|
Oh and not to forget, all those php programmers that use inline css in stead of using a style.css.... (sorry :-) but it is giving me a headache... |
Beta Was this translation helpful? Give feedback.
-
Feel free to contribute to e107 by submitting PR's where you change hardcoded output to templates. It may be wise to discuss your proposed changes first, as some of the output may be deliberately hardcoded to avoid other issues. |
Beta Was this translation helpful? Give feedback.
-
@Moc I try, but they're stuck in pull limbo.... |
Beta Was this translation helpful? Give feedback.
-
|
@CaMer0n can you take a look at these PRs please? |
Beta Was this translation helpful? Give feedback.
-
|
@rica-carv Can you write me your definition of shortcode in e107 environment then? For me, it is any HTML output for use in templates. So it is correct to use HTML directly in shortcode, it is not an issue if shortcode has good logic. Wrappers are only for shortcodes that are not mandatory (like the second password field in the signup template) or images in news... If your shortcode has always output (like forum posts), using a wrapper is useless. If your output of the shortcode depends on parameters, it should be managed by the shortcode itself. Don't do more mess with shortcodes than already is. Using shortcodes in wrapper itself is creating a headache for me. Otherwise, I got your point. Rules for shortcode should be that all HTML output can be manipulated by parameters... like class, style, wrap, use link or not etc... Or with preferences. There are many examples. What you are trying to do - there is already an example for this in core by CaMeRon, it is the parameter for shortcode... I can't remember where it is used now, but you can name it however you like. Freely try to use it as you want, you may find that wrappers will not work as you think (first using takes everything)... I was there too. @Alex-e107nl Unfortunately, inline styling (and inline javascript) is more popular nowadays. It is related to visual editors... @rica-carv By the way, don't you have in your plugin global shortcode (from e_shortcode)? Any. If you use it in the plugin template, do you happen to know if it's working for you? It is working for the theme template for me only. I can't remember if this is intentional or not. |
Beta Was this translation helpful? Give feedback.
-
Shortcodes should only output staritgth text, and all the html should be written at template level.
Ok, now you tell me what if the shortcode needs a custom style or whatever. Ok, that's what parameters are for, but for me, tehy should be used only for that.
Not quite. For instance, i use wrappers everywhere, and they're very handy...
Sorry, don't see why, can you explain?
For instance, right now, i want to customize the URL output of the See? Otherwise i would have to rewrite the complete shortcode inside my theme just to customize my link.... And when teh shortcode was changed in the future inside e107, i would have to go back and rewrite it again.... Is that good? I don't think so....
Once more, they work, they just need a little tune up and a little understanding....
But it's the wrong way to do it. Talk to any webdesigner and it will tell you it's bad practice. Imagine scavenge through embebed css just to switch links colors. Yikes!!!!
Last time i checked, it was working sitewide, but i don't have to much plugins where i use them. Let me check and i'll get back to you, ok? |
Beta Was this translation helpful? Give feedback.
-
I want to customize wrapping around two shortcodes with different parms, for instance:
right now i have to "hardcode" them inside the HTML, like this:
Is there any chance to use wrappers around them?
This is not working:
But other simple wrappers do work, like for instance:
Beta Was this translation helpful? Give feedback.
All reactions