Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ios_fill_fake_data sometimes generates points where the speed is greater than the speed of sound #848

Open
shankari opened this issue Jan 25, 2023 · 1 comment

Comments

@shankari
Copy link
Contributor

In test TestPipelineRealData.testIosJumpsAndUntrackedSquishing, for the second section, we insert an entry because there is a large iOS gap

2023-01-24 21:54:17,644:DEBUG:4623691264:Found 1 large gaps, filling them all
2023-01-24 21:54:17,644:DEBUG:4623691264:Found large gap ending at 8, filling it
2023-01-24 21:54:17,644:DEBUG:4623691264:start = 7, end = 8, generating entries between 1469075385.999996 and 1469075445.999997

And this apparently inserts a point which is over the speed of sound

2023-01-24 21:54:17,737:INFO:4623691264:After first round, still have outliers    index  ...         speed
1      1  ...  6.616681e+00
9      8  ...  3.411318e+07
After first round, recomputed max = 34113180.058238134, recomputed threshold = 1.7570292255633762

This is because the timedelta for the point is very small

Distance delta = 51.28756532378865 and time delta = 41.999999046325684
Distance delta = 22.49458343565475 and time delta = 60.0
Distance delta = 32.436446584498526 and time delta = 9.5367431640625e-07
Distance delta = 50.28642549839274 and time delta = 40.995925188064575

Although the point is not an outlier

Before fill After fill
Screen Shot 2023-01-24 at 10 12 03 PM Screen Shot 2023-01-24 at 10 12 26 PM
@shankari
Copy link
Contributor Author

Now that our default data collection speed is every meter, we are less likely to run into this. So deferring an investigation and a fix until later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant