-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NC21 - Not saving anything #33
Comments
Same issue here, please fix it. |
I have the same issue in NC 20 with the version 1.4.6. I reverted to the version 1.4.5 and it retains at least the last position ! EDIT : after switching to NextCloud 22 and the master branch, it saves the last position 👍 |
Any update on this? |
It would be reallly awesome to enable the saving of comments/annotations so that EPUBs can be reviewed by colleagues. |
Same issue here. EDIT: Display settings (page width, custom colors, etc.) don't seem to save either. |
New and fresh install Nextcloud 23 with EPUB/CBZ/PDF ebook reader 1.4.7 |
I think I discovered why it won't save anything on some instance :
So as for now, if you can activated the URL using "mod_rewrite" (or check if there is no missing "RewriteBase /" in the .htaccess file) it should save everything. |
muffin-1 = Mameka, sry. |
The issue is in the epubreader app, not in your nextcloud installation. I tried to fix the saving for epub files in PR #42 Could other users try this fix and give me feedback ? |
how did you manage to revert it? when I just copy untarred 1.4.5 release, it produces an internal server error. |
I "reverted" it by moving the app to the standard app folder "apps", instead of the customer one I created. IMHO, to get the last position saving to work, you must have the latest version n the "apps" folder, and no other "epubreader" folder in any custom apps directory. |
I tried the latest version of epubreader on clean installs of NC 22 and 23 and it didn't work. Are you saying that by default the app is installed into the wrong folder? |
Does your install have URL rewriting activated ? |
do you mean mod_rewrtite? It was enabled on the .htaccess file, but I was running from docker and I am not very familiar with it. |
The mod_rewrite needs to be activated on Apache side and on the next loud instance. The URL of your "apps" should not contain "index.php" |
It is enabled in both places
RewriteEngine on RewriteCond %{HTTP_USER_AGENT} DavClnt RewriteRule ^$ /remote.php/webdav/ [L,R=302] RewriteRule .* - [env=HTTP_AUTHORIZATION:%{HTTP:Authorization}] RewriteRule ^\.well-known/carddav /remote.php/dav/ [R=301,L] RewriteRule ^\.well-known/caldav /remote.php/dav/ [R=301,L] RewriteRule ^remote/(.*) remote.php [QSA,L] RewriteRule ^(?:build|tests|config|lib|3rdparty|templates)/.* - [R=404,L] RewriteRule ^\.well-known/(?!acme-challenge|pki-validation) /index.php [QSA,L] RewriteRule ^(?:\.(?!well-known)|autotest|occ|issue|indie|db_|console).* - [R> but it still doesn't make a difference :( |
HA! |
Having said that, it only remembers an approximate position, it's a couple pages off (for epub anyway, I haven't tested PDF yet). I wonder why that is. |
My PR is very experimental (and to be honest, it seems to break some other things ; I need to dig very deep to fix this IMHO). You need to "force" Nextcloud to use the "Pretty URLs" to make it work in the actual version : https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#pretty-urls |
These lines 'overwrite.cli.url' => 'https://example.org/nextcloud', were already present in my config file and the progress sync didn't work until I implemented the PR |
The way the URLs are handled in nextcloud is very obscure to me ; it seems it's more complicated than I thought, because, for me this configuration works for me (outside docker). |
Hi, I found the issue really intrusive, and digged a bit to understand where it could be going wrong, here are my findings:
Why?If you look at the Nextcloud custom apps design, all of them need to write a routes.php (e.g. https://github.com/e-alfred/epubreader/blob/master/appinfo/routes.php) and Nextcloud would serve it over the Temporary workaroundUse a Chrome extension like Requestly. This can rewrite the requests on the fly. Example configuration: |
Latest release opens books fine but does not save progress, bookmarks, settings etc.
The text was updated successfully, but these errors were encountered: