Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot de-select PDF from file types for which Reader should be the default viewer #27

Open
dysonsphere-startmail opened this issue Dec 20, 2020 · 10 comments
Labels
bug Something isn't working

Comments

@dysonsphere-startmail
Copy link

In Settings > Additional Settings I try to de-select Reader from opening PDFs.
I get a "saving..." message that hangs.
The setting never sticks.

Nextcloud: 20.0.4
EPUB/CBZ/PDF ebook reader: 1.4.5

@JazMTaz
Copy link

JazMTaz commented Dec 28, 2020

Same issue for me here also using Nextcloud 20.0.4, EPUB/CBZ/PDF ebook reader: 1.4.5

@m0yP
Copy link

m0yP commented Dec 28, 2020

Same here! I have several shared PDFs and when accessing them it loads the default view (which is fine) but also a pop-up window with the reader!

@szaimen
Copy link

szaimen commented Jan 11, 2021

Would love this, too :)
Actually, this is the only issue that is preventing me from installing the app currently

@rhein
Copy link

rhein commented Jan 13, 2021

This is actually the same bug as issue #20

@D1reW0lf
Copy link

D1reW0lf commented May 6, 2021

Hi.

Just want to add my "me too" on this problem.
Running EPUB/CBZ/PDF ebook reader 1.4.6 on NextCloud 20.0.9 and I can't de-select the PDF option.

Also it wouldn't be a bad idea to have a global option to prevent EPUB/CBZ/PDF ebook reader of "overtake" the PDF on the whole server and for the whole users.

Thanks
Pedro

@e-alfred e-alfred added the bug Something isn't working label Aug 7, 2021
@Kevin8675
Copy link

Still having this issue in 1.4.7 with NC 23. I am able to deselect it, but it will just say "Saving..." and when I reload, it is selected again.

@manuelkamp
Copy link

bump (is any dev here around and reading any comments?)

@TheNomad11
Copy link

yeah, such a useful app, it should be part of the core actually, but I had to uninstall again because of this issue.

@sysadminstory
Copy link

sysadminstory commented Jan 20, 2022

I searched a little bit why this does not work anymore.

In the App metadata, the route to save the settings is not defined like in this documentation :
https://docs.nextcloud.com/server/latest/developer_manual/basics/routing.html

I don't know how the settings are actually displayed, because there is no metadata set in this app, like in :
https://docs.nextcloud.com/server/latest/developer_manual/basics/setting.html

This must have been changed at some point in some version of Nextcloud.

The code to handle the settings change is not done in a "Controller", but in a simple file : ajax/personal.php

This app need a rework to work fully in recent version of Nextcloud.

I may give it a try, but it will be a big challenge for me :o

@sysadminstory
Copy link

My PR #41 should fix this issue.

I'm not a Nextcloud app developper, so this PR needs to be reviewed before being production ready !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests