-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot de-select PDF from file types for which Reader should be the default viewer #27
Comments
Same issue for me here also using Nextcloud 20.0.4, EPUB/CBZ/PDF ebook reader: 1.4.5 |
Same here! I have several shared PDFs and when accessing them it loads the default view (which is fine) but also a pop-up window with the reader! |
Would love this, too :) |
This is actually the same bug as issue #20 |
Hi. Just want to add my "me too" on this problem. Also it wouldn't be a bad idea to have a global option to prevent EPUB/CBZ/PDF ebook reader of "overtake" the PDF on the whole server and for the whole users. Thanks |
Still having this issue in 1.4.7 with NC 23. I am able to deselect it, but it will just say "Saving..." and when I reload, it is selected again. |
bump (is any dev here around and reading any comments?) |
yeah, such a useful app, it should be part of the core actually, but I had to uninstall again because of this issue. |
I searched a little bit why this does not work anymore. In the App metadata, the route to save the settings is not defined like in this documentation : I don't know how the settings are actually displayed, because there is no metadata set in this app, like in : This must have been changed at some point in some version of Nextcloud. The code to handle the settings change is not done in a "Controller", but in a simple file : ajax/personal.php This app need a rework to work fully in recent version of Nextcloud. I may give it a try, but it will be a big challenge for me :o |
My PR #41 should fix this issue. I'm not a Nextcloud app developper, so this PR needs to be reviewed before being production ready ! |
In Settings > Additional Settings I try to de-select Reader from opening PDFs.
I get a "saving..." message that hangs.
The setting never sticks.
Nextcloud: 20.0.4
EPUB/CBZ/PDF ebook reader: 1.4.5
The text was updated successfully, but these errors were encountered: