From 80ea27df4dd858b686d91ef37dad89aa8cd89439 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Tue, 11 Aug 2020 18:37:37 +0200 Subject: [PATCH] Remove exception.escaped attribute (as per SIG mtg). --- specification/trace/api.md | 4 ++-- specification/trace/semantic_conventions/exceptions.md | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/specification/trace/api.md b/specification/trace/api.md index 2991233ae7a..c3c1058417f 100644 --- a/specification/trace/api.md +++ b/specification/trace/api.md @@ -516,8 +516,8 @@ MUST record an exception as an `Event` with the conventions outlined in the Examples: -- `RecordException(exception: Exception, escaped: boolean? = null)` -- `RecordException(type: String, message: String, stacktrace: String, escaped: boolean?)` +- `RecordException(exception: Exception)` +- `RecordException(type: String, message: String, stacktrace: String)` ### Span lifetime diff --git a/specification/trace/semantic_conventions/exceptions.md b/specification/trace/semantic_conventions/exceptions.md index a84e7fe4274..b90d753a2f0 100644 --- a/specification/trace/semantic_conventions/exceptions.md +++ b/specification/trace/semantic_conventions/exceptions.md @@ -43,7 +43,7 @@ Span span = myTracer.startSpan(/*...*/); try { // original code } catch (Throwable e) { - span.recordException(e, /*escaped=*/true); + span.recordException(e); // We know that the exception is escaping here. throw e; } finally { span.end(); @@ -60,7 +60,6 @@ their types. | exception.type | String | The type of the exception (its fully-qualified class name, if applicable). The dynamic type of the exception should be preferred over the static type in languages that support it. E.g. "java.net.ConnectException", "OSError" | One of `exception.type` or `exception.message` is required | | exception.message | String | The exception message. E.g. `"Division by zero"`, `"Can't convert 'int' object to str implicitly"` | One of `exception.type` or `exception.message` is required | | exception.stacktrace | String | A stacktrace as a string in the natural representation for the language runtime. The representation is to be determined and documented by each language SIG. E.g. `"Exception in thread \"main\" java.lang.RuntimeException: Test exception\n at com.example.GenerateTrace.methodB(GenerateTrace.java:13)\n at com.example.GenerateTrace.methodA(GenerateTrace.java:9)\n at com.example.GenerateTrace.main(GenerateTrace.java:5)"`. | No | -| exception.escaped | Bool | SHOULD be set to true if the exception event is recoded at a point where it is known that the exception is escaping the scope of the span (e.g. if there is an exception active just before ending the Span). Note that an exception may still leave the scope of the span even if this was not set or set to false, if the event was recorded at an earlier time. | No | ### Stacktrace Representation