From 44d21fe5030d2f64bedde1efc50a1173e0c49f3d Mon Sep 17 00:00:00 2001 From: William Armiros <54150514+willarmiros@users.noreply.github.com> Date: Fri, 22 Oct 2021 12:18:46 -0700 Subject: [PATCH] feat: bumped aws components to 1.0 (#658) * chore: bumped aws components to 1.0 * chore: fixed link in docs to be consistent Release-As: 1.0.0 * chore: cleaned up idgenerator readme Release-As: 1.0.0 * chore: cleaned up propagator readme Release-As: 1.0.0 * chore: updated sdk to 1.0.0 * updated readme for trace id generator Co-authored-by: Rauno Viskus Co-authored-by: Bartlomiej Obecny --- .../opentelemetry-resource-detector-aws/README.md | 2 +- .../opentelemetry-resource-detector-aws/package.json | 2 +- .../opentelemetry-id-generator-aws-xray/README.md | 12 +++--------- .../opentelemetry-propagator-aws-xray/README.md | 2 +- 4 files changed, 6 insertions(+), 12 deletions(-) diff --git a/detectors/node/opentelemetry-resource-detector-aws/README.md b/detectors/node/opentelemetry-resource-detector-aws/README.md index 01b74e1446f..4135a7be1b7 100644 --- a/detectors/node/opentelemetry-resource-detector-aws/README.md +++ b/detectors/node/opentelemetry-resource-detector-aws/README.md @@ -31,7 +31,7 @@ const tracerProvider = new NodeTracerProvider({ resource }); ## Available detectors -- `awsBeanstalkDetector`: Populates `service` for processes running on [AWS Elastic Beanstalk](https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/Welcome.html) +- `awsBeanstalkDetector`: Populates `service` for processes running on [AWS Elastic Beanstalk](https://aws.amazon.com/elasticbeanstalk/) - `awsEc2Detector`: Populates `cloud` and `host` for processes running on [Amazon EC2](https://aws.amazon.com/ec2/), including abstractions such as ECS on EC2. Notably, it does not populate anything on AWS Fargate - `awsEcsDetector`: Populates `container` for containers running on [Amazon ECS](https://aws.amazon.com/ecs/) - `awsEksDetector`: Populates `container` and `k8s.cluster_name` for containers running on [Amazon EKS](https://aws.amazon.com/eks/) diff --git a/detectors/node/opentelemetry-resource-detector-aws/package.json b/detectors/node/opentelemetry-resource-detector-aws/package.json index d7b81133d38..38970b55730 100644 --- a/detectors/node/opentelemetry-resource-detector-aws/package.json +++ b/detectors/node/opentelemetry-resource-detector-aws/package.json @@ -44,7 +44,7 @@ }, "devDependencies": { "@opentelemetry/api": "1.0.2", - "@opentelemetry/contrib-test-utils": "^0.25.0", + "@opentelemetry/contrib-test-utils": "^0.26.0", "@types/mocha": "8.2.3", "@types/node": "14.17.9", "@types/sinon": "10.0.2", diff --git a/packages/opentelemetry-id-generator-aws-xray/README.md b/packages/opentelemetry-id-generator-aws-xray/README.md index f9a9819f9cf..fc203d4feb2 100644 --- a/packages/opentelemetry-id-generator-aws-xray/README.md +++ b/packages/opentelemetry-id-generator-aws-xray/README.md @@ -40,16 +40,10 @@ const tracerProvider = new NodeTracerProvider(tracerConfig); Example trace ID format: 58406520a006649127e371903a2de979 -A trace ID consists of two parts; the timestamp and the unique identifier. +A trace ID consists of two parts: -#### Time Stamp - -* the first 8 hexadecimal digits represent the time of the original request in Unix epoch time -* for example, 10:00AM December 1st, 2016 PST in epoch time is 1480615200 seconds, or 58406520 in hexadecimal digits. - -#### Unique Identifier - -* the last 24 hexadecimal digits is an random identifier for the trace +1. **Timestamp**: The first 8 hexadecimal digits represent the time of the original request in Unix epoch time. For example, 10:00 AM December 1st, 2016 PST in epoch time is 1480615200 seconds, or 58406520 in hexadecimal digits. +2. **Unique Identifier**: The last 24 hexadecimal digits is an random identifier for the trace. ## Useful links diff --git a/propagators/opentelemetry-propagator-aws-xray/README.md b/propagators/opentelemetry-propagator-aws-xray/README.md index 7684ff63354..077644a1853 100644 --- a/propagators/opentelemetry-propagator-aws-xray/README.md +++ b/propagators/opentelemetry-propagator-aws-xray/README.md @@ -56,7 +56,7 @@ For additional reading, see the [AWS X-Ray Trace ID](https://docs.aws.amazon.com * 64-bit random number in base16 format. Populated from the [OpenTelemetry Span ID](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/overview.md#spancontext). -#### Sampled - The sampling decision* +#### Sampled - The sampling decision * Defined in the AWS X-Ray specification as a tri-state field, with "0", "1" and "?" as valid values. Only "0" and "1" are used in this propagator. If "?", a new trace will be started. * Populated from the [OpenTelemetry trace flags](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/overview.md#spancontext).