Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic pagination/aggregation for Query and Scan #102

Closed
strygin opened this issue Jan 18, 2017 · 5 comments
Closed

Automatic pagination/aggregation for Query and Scan #102

strygin opened this issue Jan 18, 2017 · 5 comments

Comments

@strygin
Copy link
Contributor

strygin commented Jan 18, 2017

I'm going to implement automatic paginated request wrapper built-in in Query and Scan, because of DynamoDB chuck's size limit of 1Mb. Even if you just need to get a count of matching rows (without returning any other data), Query and Scan cannot return correct results in a single request if it goes thru more 1MB of data (keys or rows) on its side for analyzing. For example count will be unaggregated. Pretty hard to demonstrate it using tests, because I need to feed a test DB with 10's of thousands rows in order for an index footprint to overflow 1Mb.

@strygin
Copy link
Contributor Author

strygin commented Jan 18, 2017

If you wonder which count I'm talking about, checkout this PR: #101

@brandongoode
Copy link
Contributor

I overlooked this. That would be great. Let me know if you need any help.

@strygin
Copy link
Contributor Author

strygin commented Feb 9, 2017

Will work on it this weekend

@yusufar
Copy link

yusufar commented Apr 13, 2017

@brandongoode when this is going to come as a new version?

@brandongoode
Copy link
Contributor

@yusufar No ETA on the release date. I have to find some time to clean up some loose ends and then will be working on the next release.

For now, you can pull directly from the repo. I try to make sure master is always stable, but I would recommend referencing a commit to make sure changes don't impact you.

"dependencies": {
  "package": "git://github.com/automategreen/dynamoose.git#commit"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants