Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: double check modules are all using cosmos 47 param style #1416

Closed
danwt opened this issue Nov 6, 2024 · 2 comments
Closed

Migration: double check modules are all using cosmos 47 param style #1416

danwt opened this issue Nov 6, 2024 · 2 comments
Assignees

Comments

@danwt
Copy link
Contributor

danwt commented Nov 6, 2024

In cosmos 47 params should now all be kept in module rather than in x/params

https://docs.cosmos.network/main/build/migrations/upgrading#xparams

Need to check we do it everywhere, and run a migration if not

Example cosmos/cosmos-sdk#12363

@mtsitrin
Copy link
Contributor

mtsitrin commented Nov 6, 2024

we don't do it in most of our code base
it's backward compatibility, so not sure regarding the priority for this
we have all osmo and ethermint to migrate, and some of our modules

@danwt
Copy link
Contributor Author

danwt commented Nov 6, 2024

I see, it seems like it's only mandatory if upgrading to v50
closing for now

@danwt danwt closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants