Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split cats-effect and fs2 dependencies out of Core #34

Merged
merged 12 commits into from
Jul 1, 2022
Merged

Conversation

dylemma
Copy link
Owner

@dylemma dylemma commented May 13, 2022

This is to avoid the dependency hell that is the cats-effect 2.x -> 3.x migration.

The main points:

  • Adds the spac-interop-fs2 module to house all of the CE3-friendly stuff like transformer.toPipe and parser.parseF(stream)
  • Adds the Source[A] type to Core that's essentially a Resource[Fallible, Iterator[A]] that's friendly for synchronous-style parsing but also can be converted to a Stream[F, A] easily.
  • Made it so there are less implicits involved with being able to call .parse on something. All of the *Support imports are gone; instead you explicitly call e.g. JavaxSource.fromFile to get a Source which can be passed to a Parser. The Parsable typeclass is gone.

@dylemma dylemma marked this pull request as ready for review June 30, 2022 04:03
@dylemma dylemma merged commit 8c4e9df into main Jul 1, 2022
@dylemma dylemma deleted the dev/v0.10 branch July 1, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant