Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Info string option implementation #119

Merged
merged 9 commits into from
May 1, 2024

Conversation

Cypher1
Copy link
Collaborator

@Cypher1 Cypher1 commented Apr 13, 2024

Fixes #1 and refactors some config/options management from #118

Note: This is a stacked change including
#118

@Cypher1
Copy link
Collaborator Author

Cypher1 commented Apr 26, 2024

@dylanowen Could I get a review for this?

dylanowen
dylanowen previously approved these changes Apr 26, 2024
Copy link
Owner

@dylanowen dylanowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! The only missing pieces are updating the Readme and bumping the version (probably a minor bump)

@Cypher1
Copy link
Collaborator Author

Cypher1 commented Apr 30, 2024

Sorry @dylanowen I added some doc. Could you review?

Copy link
Owner

@dylanowen dylanowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Cypher1 Cypher1 merged commit 5636dc2 into dylanowen:master May 1, 2024
5 checks passed
@Cypher1 Cypher1 deleted the infoString branch May 1, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for configuring the info string used to identify Graphviz code blocks
2 participants