Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deep link attribute #116

Merged
merged 1 commit into from
Aug 22, 2024
Merged

feat: add deep link attribute #116

merged 1 commit into from
Aug 22, 2024

Conversation

dylandoamaral
Copy link
Owner

close #115

@dylandoamaral dylandoamaral merged commit c20a822 into main Aug 22, 2024
3 checks passed
@dylandoamaral dylandoamaral deleted the feat/add-deep-link branch August 22, 2024 07:04
@doctorkb
Copy link

Thanks! I'm happy to test this if you can put it in a release (or "pre-release") for HACS...

@dylandoamaral
Copy link
Owner Author

I will add another commit tonight and do the release !

@doctorkb
Copy link

This works GREAT! Thank you!

As a troubleshooting point that you may run into... HACS has an old upcoming-media-card repo. You have to manually add the new one: https://github.com/custom-cards/upcoming-media-card see: custom-cards/upcoming-media-card#99 (comment)

Now for an even better if... the deep link linked directly to the episode, not just the show. 🙂

@dylandoamaral
Copy link
Owner Author

dylandoamaral commented Aug 23, 2024

It may be interesting for you to do it yourself and make a PR, it is just one line of code ;)? Hint: check the line changed in this PR and the URL in trakt website that links to the episode.

@doctorkb
Copy link

You're right, I could probably figure out the code. But I don't have the several hours to familiarize myself with git and building the test environment so I don't have to be restarting my normal HA instance to test and perfect that little bit of code.

I appreciate what you've done so far -- if I've asked too much, I'm sorry. I just thought I'd add the suggestion for improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deep_link attribute
2 participants