FreeBSD Host Model Patch #1588
FreeBSD Host Model Patch #1588
Conversation
|
Ignore commit |
| if [[ $(uname -s) = "FreeBSD" ]]; then | ||
| model=$(kenv smbios.system.version) | ||
| else | ||
| model=$(sysctl -n hw.vendor hw.product) | ||
| fi |
There was a problem hiding this comment.
Look at other code in neofetch to see how to detect OS/Distro name. There are variables which can be used.
There was a problem hiding this comment.
Look at other code in neofetch to see how to detect OS/Distro name. There are variables which can be used.
You could have just changed it to $kernel_name for them... or at least tell them that it should be $kernel_name. Not every contributor have time to read through like 13k lines of bash code
Upstream PR: dylanaraps/neofetch#1588 Thanks to @dvogit Co-authored-by: Dvonik <[email protected]>
|
Thank you for your contribution! This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained. HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo. Read the "Running Updated Original Neofetch" section for more info! |
I noticed that my host model wasn't recognized so I made a patch taking advantage of the
kenvcommand in FreeBSD.The previous
sysctlvalues used to get the host model were deprecated for a few years so I decided to update it.