Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow configuring full preupgrade version name (backport #2108) #2113

Merged
merged 1 commit into from
Aug 20, 2024
Merged

allow configuring full preupgrade version name (backport #2108) #2113

merged 1 commit into from
Aug 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 20, 2024

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features
    • Improved version naming conventions for upgrade tests.
    • Introduced a new version declaration file for better version tracking (VERSION_FULL_NAME_PREUPGRADE).
  • Documentation
    • Enhanced README with detailed versioning information, including the new variable VERSION_FULL_NAME_PREUPGRADE.
  • Bug Fixes
    • Updated the download URL construction for the pre-upgrade binary to use a more descriptive version identifier.
This is an automatic backport of pull request #2108 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Aug 20, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 20, 2024

Cherry-pick of 5998dfc has failed:

On branch mergify/bp/release/protocol/v6.x/pr-2108
Your branch is up to date with 'origin/release/protocol/v6.x'.

You are currently cherry-picking commit 5998dfc2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   protocol/testing/containertest/containertest.sh
	new file:   protocol/testing/version/VERSION_FULL_NAME_PREUPGRADE

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   protocol/testing/version/README.md
	deleted by us:   protocol/testing/version/version.sh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Aug 20, 2024
Merged
6 tasks
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 20, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roy-dydx roy-dydx force-pushed the mergify/bp/release/protocol/v6.x/pr-2108 branch from d2da4ca to 604cc56 Compare August 20, 2024 18:11
@roy-dydx roy-dydx force-pushed the mergify/bp/release/protocol/v6.x/pr-2108 branch from 604cc56 to 2f2e2d6 Compare August 20, 2024 18:36
@roy-dydx roy-dydx merged commit af25ad8 into release/protocol/v6.x Aug 20, 2024
22 of 23 checks passed
@roy-dydx roy-dydx deleted the mergify/bp/release/protocol/v6.x/pr-2108 branch August 20, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roy-dydx roy-dydx roy-dydx approved these changes

@vincentwschau vincentwschau vincentwschau approved these changes

@chenyaoy chenyaoy chenyaoy approved these changes

Assignees

@roy-dydx roy-dydx

Labels
conflicts protocol
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyaoy @vincentwschau @roy-dydx