From 8afbcccc067ebb3f441a6eaf45f33f84539c10d0 Mon Sep 17 00:00:00 2001 From: Will Liu Date: Wed, 7 Aug 2024 12:19:29 -0400 Subject: [PATCH 1/3] bump grpc stream defaults --- protocol/app/flags/flags.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/protocol/app/flags/flags.go b/protocol/app/flags/flags.go index bdbe34a514..72cc8bef6f 100644 --- a/protocol/app/flags/flags.go +++ b/protocol/app/flags/flags.go @@ -64,8 +64,8 @@ const ( DefaultGrpcStreamingEnabled = false DefaultGrpcStreamingFlushIntervalMs = 50 - DefaultGrpcStreamingMaxBatchSize = 2000 - DefaultGrpcStreamingMaxChannelBufferSize = 2000 + DefaultGrpcStreamingMaxBatchSize = 100000 + DefaultGrpcStreamingMaxChannelBufferSize = 100000 DefaultVEOracleEnabled = true DefaultOptimisticExecutionEnabled = false From cedbeb3b6393489999085c697264f422d2143063 Mon Sep 17 00:00:00 2001 From: Will Liu Date: Wed, 7 Aug 2024 13:00:26 -0400 Subject: [PATCH 2/3] ut + bump up --- protocol/app/flags/flags.go | 4 ++-- protocol/app/flags/flags_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/protocol/app/flags/flags.go b/protocol/app/flags/flags.go index 72cc8bef6f..74d72e46a9 100644 --- a/protocol/app/flags/flags.go +++ b/protocol/app/flags/flags.go @@ -64,8 +64,8 @@ const ( DefaultGrpcStreamingEnabled = false DefaultGrpcStreamingFlushIntervalMs = 50 - DefaultGrpcStreamingMaxBatchSize = 100000 - DefaultGrpcStreamingMaxChannelBufferSize = 100000 + DefaultGrpcStreamingMaxBatchSize = 1000000 + DefaultGrpcStreamingMaxChannelBufferSize = 1000000 DefaultVEOracleEnabled = true DefaultOptimisticExecutionEnabled = false diff --git a/protocol/app/flags/flags_test.go b/protocol/app/flags/flags_test.go index 8260efe313..672fa6992c 100644 --- a/protocol/app/flags/flags_test.go +++ b/protocol/app/flags/flags_test.go @@ -80,8 +80,8 @@ func TestValidate(t *testing.T) { GrpcEnable: true, GrpcStreamingEnabled: true, GrpcStreamingFlushIntervalMs: 100, - GrpcStreamingMaxBatchSize: 2000, - GrpcStreamingMaxChannelBufferSize: 2000, + GrpcStreamingMaxBatchSize: 1000000, + GrpcStreamingMaxChannelBufferSize: 1000000, }, }, "success - optimistic execution": { From f371a72676c5c47ccc6912b96846b251c05aa8e5 Mon Sep 17 00:00:00 2001 From: Will Liu Date: Wed, 7 Aug 2024 13:39:01 -0400 Subject: [PATCH 3/3] fix tests --- protocol/app/flags/flags_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/protocol/app/flags/flags_test.go b/protocol/app/flags/flags_test.go index 672fa6992c..3aac1ebed7 100644 --- a/protocol/app/flags/flags_test.go +++ b/protocol/app/flags/flags_test.go @@ -130,7 +130,7 @@ func TestValidate(t *testing.T) { GrpcEnable: true, GrpcStreamingEnabled: true, GrpcStreamingFlushIntervalMs: 0, - GrpcStreamingMaxBatchSize: 2000, + GrpcStreamingMaxBatchSize: 1000000, }, expectedErr: fmt.Errorf("grpc streaming flush interval must be positive number"), }, @@ -140,7 +140,7 @@ func TestValidate(t *testing.T) { GrpcEnable: true, GrpcStreamingEnabled: true, GrpcStreamingFlushIntervalMs: 100, - GrpcStreamingMaxBatchSize: 2000, + GrpcStreamingMaxBatchSize: 1000000, GrpcStreamingMaxChannelBufferSize: 0, }, expectedErr: fmt.Errorf("grpc streaming channel size must be positive number"), @@ -183,8 +183,8 @@ func TestGetFlagValuesFromOptions(t *testing.T) { expectedGrpcEnable: true, expectedGrpcStreamingEnable: false, expectedGrpcStreamingFlushMs: 50, - expectedGrpcStreamingBatchSize: 2000, - expectedGrpcStreamingMaxChannelBufferSize: 2000, + expectedGrpcStreamingBatchSize: 1000000, + expectedGrpcStreamingMaxChannelBufferSize: 1000000, expectedOptimisticExecutionEnabled: false, }, "Sets values from options": {