Fix exception when closing a position of > 100% margin usage #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruixhuang
commented
Dec 2, 2024
| @@ -109,7 +109,12 @@ internal class TradeInputMarketOrderCalculator() { | |||
| val tradeSize = trade.size | |||
| val freeCollateral = subaccount?.calculated?.get(CalculationPeriod.current)?.freeCollateral | |||
|
|
|||
| if (tradeSize != null && tradeSide != null && freeCollateral != null && freeCollateral > Numeric.double.ZERO) { | |||
| val freeCollateralCondition = if (trade.reduceOnly) { | |||
There was a problem hiding this comment.
Don't need to check freeCollateral > 0 if the trade is reduceOnly.
ruixhuang
commented
Dec 2, 2024
| } catch (e: Exception) { | ||
| val error = V4TransactionErrors.error(null, e.toString()) | ||
| trackTransactionError("placeOrderPayload", error) | ||
| throw e |
There was a problem hiding this comment.
All those "..Payload" functions are called by the web FE.. I think web code catches the exception to display the error.
Here we just catch the exception for logging and re-throw it.
jaredvu
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding tracking code to log client-side exceptions like this.