fix(server): fix crash when session token returns no data in auth middleware #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-11-07 13:14:47.234482078 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-11-07 13:14:47.798483322 +0000
@@ -45,5 +45,5 @@
dist/assets/VimeoPlayer-hash.js 39.95 kB │ gzip: 12.51 kB
dist/assets/Room-hash.js 164.04 kB │ gzip: 51.42 kB
dist/assets/GoogleDrivePlayer-hash.js 604.60 kB │ gzip: 173.41 kB
-dist/assets/index-hash.js 748.75 kB │ gzip: 250.29 kB
+dist/assets/index-hash.js 748.75 kB │ gzip: 250.28 kB
dist/assets/PlyrPlayer-hash.js 1,280.51 kB │ gzip: 379.29 kB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1814 +/- ##
================================================
+ Coverage 61.6271% 61.6292% +0.0020%
================================================
Files 169 169
Lines 25492 25496 +4
Branches 1446 1448 +2
================================================
+ Hits 15710 15713 +3
- Misses 9728 9729 +1
Partials 54 54 ☔ View full report in Codecov by Sentry. |
dyc3
deleted the
11-07-fix_server_fix_crash_when_session_token_returns_no_data_in_auth_middleware
branch
OpenTogetherTube
|
||||||||||||||||||||||||||||||||||
| Project |
OpenTogetherTube
|
| Branch Review |
11-07-fix_server_fix_crash_when_session_token_returns_no_data_in_auth_middleware
|
| Run status |
|
| Run duration | 05m 20s |
| Commit |
|
| Committer | Carson McManus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
83
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/e2e/integration/playback.spec.ts • 1 failed test • E2E - electron
| Test | Artifacts | |
|---|---|---|
| Video playback > should add and play a youtube video |
Test Replay
Screenshots
|
|
OpenTogetherTube
|
||||||||||||||||||||||||||||||||||
| Project |
OpenTogetherTube
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 05m 42s |
| Commit |
|
| Committer | Carson McManus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
1
|
|
Flaky
|
0
|
|
Pending
|
1
|
|
Skipped
|
0
|
|
Passing
|
83
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/e2e/integration/playback.spec.ts • 1 failed test • E2E - electron
| Test | Artifacts | |
|---|---|---|
| Video playback > should add and play a youtube video |
Test Replay
Screenshots
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1813