server: fix bulk add preview caching #1787
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
requested changes
Aug 19, 2024
Comment on lines
+279
to
+280
| } else if (videoKeys.length > 2) { | ||
| return video; |
There was a problem hiding this comment.
You're right it's still broken. I don't think this approach is correct, I'll revise it.
The branch is to only return the video if the video is found in the cache, since it should contain more than the VideoId fields then.
There was a problem hiding this comment.
This is incorrect behavior then. We need to be able to return videos that were not already in the cache.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1787 +/- ##
================================================
+ Coverage 61.6161% 61.6170% +0.0008%
================================================
Files 169 169
Lines 25443 25454 +11
Branches 1447 1449 +2
================================================
+ Hits 15677 15684 +7
- Misses 9712 9716 +4
Partials 54 54 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1289. Also filters videos that failed to fetch from being returned to the client.