workaround for passport bug to ensure redir auth

see: + jaredhanson/passport#401 + jaredhanson/passport#306
dxwc · Jan 11, 2019 · a66b681 · a66b681
1 parent 357f2d7
commit a66b681
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/controller/sign_in.js b/controller/sign_in.js
@@ -75,9 +75,12 @@ router.post('/sign_in', (req, res) =>
                     else
                     {
                         delete req.session.captcha_solution;
-                        res.setHeader('Cache-Control', 'no-cache');
-                        return res.redirect
-                        (req.session.previous ? req.session.previous : '/');
+                        req.session.save((err) =>
+                        {
+                            if(err) console.error(err);
+                            return res.redirect
+                            (req.session.previous ? req.session.previous : '/');
+                        });
                     }
                 });
             }

diff --git a/controller/sign_out.js b/controller/sign_out.js
@@ -9,8 +9,11 @@ router.get('/sign_out', (req, res) =>
 router.post('/sign_out', (req, res) =>
 {
     req.logOut();
-    res.setHeader('Cache-Control', 'no-cache');
-    return res.redirect(req.session.previous ? req.session.previous : '/');
+    req.session.save((err) =>
+    {
+        if(err) console.error(err);
+        return res.redirect(req.session.previous ? req.session.previous : '/');
+    });
 });
 
 module.exports = router;
diff --git a/controller/sign_up.js b/controller/sign_up.js
@@ -102,9 +102,12 @@ router.post('/sign_up', (req, res) =>
                         else
                         {
                             delete req.session.captcha_solution;
-                            res.setHeader('Cache-Control', 'no-cache');
-                            return res.status(200).redirect
-                            (req.session.previous ? req.session.previous : '/');
+                            req.session.save((err) =>
+                            {
+                                if(err) console.error(err);
+                                return res.redirect
+                                (req.session.previous ? req.session.previous : '/');
+                            });
                         }
                     });
                 }