Documentation for Heroku deployment #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2017 15:29
nelsonic
added
enhancement
in-review
and removed
awaiting-review
discuss
help wanted
labels
nelsonic
approved these changes
Feb 8, 2017
There was a problem hiding this comment.
@jruts this is fantastic!! 😍
Only thing I would change would be to exclude the img/ because it encourages people to include Binary files in the repo (which take up a lot of space and make it slower for people who aren't on good internet connections to download/clone the repo...) 🤔
see: https://github.com/dwyl/contributing#images-and-binary-files
Instead we prefer to drag-and-drop the images into a GitHub issue and then paste the resulting uploaded image's link in the markdown file. 👍
nelsonic
approved these changes
Feb 8, 2017
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to document on how to deploy your phoenix app on Heroku through the Heroku dashboard.
It would be awesome if someone would try and reproduce these steps to see if they get to a working result.