Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Peer Dependency for Hapi to 8.x.x #99

Merged
merged 3 commits into from
Sep 7, 2015
Merged

Drop Peer Dependency for Hapi to 8.x.x #99

merged 3 commits into from
Sep 7, 2015

Conversation

jalcine
Copy link
Member

@jalcine jalcine commented Sep 6, 2015

This allows versions below Hapi 9.0.0 to use hapi-auth-jwt2 due to a lack of an
API change in Hapi 9.0.0

@nelsonic
Copy link
Member

nelsonic commented Sep 6, 2015

@jalcine What I was saying is that we can remove the peerDependencies completely from package.json and avoid confusing people as the compatibility of this package.
But this needs to be reflected somewhere in the README.md _e.g_:

Compatibility

hapi-auth-jwt2 is compatible with both Hapi 9.x.x and 8.x.x however we recommend using the latest version of Hapi for security/performance updates.

@jalcine
Copy link
Member Author

jalcine commented Sep 7, 2015

@nelsonic Understood! I should enable emails so I can see these sooner :)

@nelsonic nelsonic self-assigned this Sep 7, 2015
@nelsonic
Copy link
Member

nelsonic commented Sep 7, 2015

@jalcine sweet! 🍭
merging.

nelsonic added a commit that referenced this pull request Sep 7, 2015
Drop Peer Dependency for Hapi to 8.x.x
@nelsonic nelsonic merged commit f2c388b into dwyl:master Sep 7, 2015
@nelsonic
Copy link
Member

nelsonic commented Sep 7, 2015

@jalcine latest version published to NPM: https://www.npmjs.com/package/hapi-auth-jwt2
Thanks again! 👍

@jalcine jalcine deleted the drop-peerdep-for-hapi-to-8 branch September 7, 2015 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants