Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Phoenix 1.6 and Elixir 1.12.3 fixes #6 #7

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Update to Phoenix 1.6 and Elixir 1.12.3 fixes #6 #7

merged 2 commits into from
Oct 6, 2021

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Oct 5, 2021 •
edited
Loading

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Oct 5, 2021
This was referenced Oct 5, 2021
Closed
Closed
Closed
SimonLab
SimonLab approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the update 👍

@SimonLab SimonLab merged commit 7d09a41 into main Oct 6, 2021
@SimonLab SimonLab deleted the update-to-latest-phoenix-issue-#6 branch October 6, 2021 09:19
@nelsonic nelsonic mentioned this pull request Oct 6, 2021
Closed
3 tasks
@nelsonic
Copy link
Member Author

nelsonic commented Oct 6, 2021

Annoyingly, the elixir_buildpack.config does not support OTP 24 ... see: #8
This PR is still fine in terms of updating the deps. But it hasn't deployed to Heroku so the demo is still the old version. 💭

@nelsonic
Copy link
Member Author

nelsonic commented Oct 6, 2021

Deploy works and auth succeeds. ✅

@nelsonic nelsonic mentioned this pull request Oct 14, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab