Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Str::squish(string $string): string must be compatible #5

Closed
danharrin opened this issue Apr 8, 2022 · 4 comments · Fixed by #6
Closed

Str::squish(string $string): string must be compatible #5

danharrin opened this issue Apr 8, 2022 · 4 comments · Fixed by #6

Comments

@danharrin
Copy link
Contributor

danharrin commented Apr 8, 2022 •
edited
Loading

In the latest Laravel version, you contributed laravel/framework#41791. Since the method signature is different to Str::squish() used in this package, it's broken.

https://flareapp.io/share/xPQ0JYDm/claim/gXBBRjjurpDfj1Jmh5snDPF3LR8DvqVy#share
@dwightwatson
Copy link
Owner

Ha, whoops.

Happy to accept a PR that fixes this otherwise I'll sort in the next couple of days.

@danharrin
Copy link
Contributor Author

danharrin commented Apr 8, 2022 •
edited
Loading

We can remove the entire method now, right? Laravel 8 compatibility.

@danharrin danharrin mentioned this issue Apr 8, 2022
Merged
@danharrin
Copy link
Contributor Author

#6

@dwightwatson
Copy link
Owner

Tagged 2.2.0 with this fix - thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Str::squish() signature
2 participants
@dwightwatson @danharrin