Consider dropping Node::update()
method
#188
Labels
bug
Something isn't working
enhancement
New feature or request
question
Further information is requested or further design needed
Currently the
Node
design includes aNode::update()
method. This method is called by the node's predecessors if they have updates they want to propagate to the node. In principal this allows nodes to more efficiently check their predecessors for updates or to eagerly update their state. However, as of writing (Dec 2024) no nodes actually use this information, and many nodes don't actually call their successor'supdate()
method.With this in mind, we should consider dropping the notion entirely. The downside is nodes will need to always check every predecessor for updates on each propagation. And it means that all nodes will update their state lazily rather than eagerly. The upside is one less virtual method call/test. Which in the case of many scalars likely has a noticeable performance difference.
The text was updated successfully, but these errors were encountered: