Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a depth limit and/or caching to Array::min(), Array::max(), etc #182

Open
arcondello opened this issue Dec 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@arcondello
Copy link
Member

Right now calling ::max() on an array symbol can trigger a dfs. It would be usful to have some way of improving that. Either memoizing, e.g.

    virtual double min(std::unordered_map<const Array*, double> memo) const {
        auto it = memo.find(this);
        if (it != memo.end()) return it->second;
        auto min_ = this->min();
        memo.emplace_hint(it, this, min_);
        return min_;
    }

or setting a depth limit

    virtual double min(ssize_t depth = -2) const {
        if (depth == -1) return inf;
        ...
    }

or both or something else.

@arcondello arcondello added the enhancement New feature or request label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant