Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding warning for advanced indexing with logical indexer #178

Open
wbernoudy opened this issue Dec 3, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@wbernoudy
Copy link
Member

Currently, we don't support boolean indexing in our implementation of advanced indexing (AdvancedIndexingNode).

If an ArrayNode which is logical is used to index another node, AdvancedIndexingNode will simply treat it as any other integer indexer, and return a selection of the first and second elements of the main array. Though this is technically correct, it is somewhat of a departure from the numpy behavior.

To help clarify this to users, we could raise a warning if the indexer is logical to say that it will be treated as an integer index.

@arcondello arcondello added the enhancement New feature or request label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants