Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding logical_xor to mathematical functions #125

Closed
jlalbers opened this issue Sep 27, 2024 · 1 comment · Fixed by #151
Closed

Consider adding logical_xor to mathematical functions #125

jlalbers opened this issue Sep 27, 2024 · 1 comment · Fixed by #151
Labels
enhancement New feature or request

Comments

@jlalbers
Copy link
Contributor

Currently, an XOR symbol can be created by composing different logical function symbols, i.e.:

sym_1 = model.binary(...)
sym_2 = model.binary(...)
xor = logical_and(
    logical_not(logical_and(sym_1, sym_2)),
    logical_or(sym_1, sym_2)
)
...

However, I imagine it would be more efficient and expressive to have a separate XOR symbol.

@arcondello arcondello added the enhancement New feature or request label Oct 1, 2024
@arcondello
Copy link
Member

Do you have a specific use case in mind? I agree it could be there for symmetry, but I'd like to add new nodes lazily rather than eagerly.

@arcondello arcondello linked a pull request Oct 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants