Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typos #61

Merged
merged 1 commit into from
Mar 16, 2024
Merged

fix: Typos #61

merged 1 commit into from
Mar 16, 2024

Conversation

kyu08
Copy link
Contributor

@kyu08 kyu08 commented Mar 15, 2024

I found them by executing typos.

If you don't mind, I would be happy to create a PR to run typos in CI. 👍

@kyu08 kyu08 changed the title fix: Typo fix: Typos Mar 15, 2024
@dustinblackman
Copy link
Owner

Good catch, thanks!
I've tried playing with typos before but got mixed results and haven't revisited. With you running it locally did any other issues come up?

@dustinblackman dustinblackman merged commit 016b417 into dustinblackman:main Mar 16, 2024
3 checks passed
@kyu08
Copy link
Contributor Author

kyu08 commented Mar 16, 2024

mixed results

Do you mean typos returns errors about the words that you want to ignore like commit hash in CHANGELOG.md or proper noun like ratatui?
If so, adding config file(should named as _typos.toml) like below resolves the issue.

[default.extend-words]
ratatui = "ratatui"

[files]
extend-exclude = ["CHANGELOG.md"]

If you run typos with the above config file, you will not get any errors from the command.
If you don't dislike, I can make a PR that adds the above config file and CI setting to run typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants