Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails without errors after upgrading from PHP 7.3 to PHP 8.2 #19

Open
JungleGenius opened this issue Aug 21, 2023 · 1 comment
Open

Comments

@JungleGenius
Copy link

First thank you for posting this with the generous licensing terms. That said I just recently updated to PHP 8.2 and it quit working, but does not throw any errors either. Normally the exec_output array looks like this:

( 
    [0] => ** Imported 1 metadata tags
    [1] => Parsed 1551 MPEG TS frames with 0 errors
    [2] => Total of 1 programs and 2 streams
    [3] => Injected 0 frames
    [4] => Finished in 4.734ms
)

But now it only outputs:

( 
    [0] => ** Imported 1 metadata tags
)

I'll be happy to offer a modest bounty to get this working again under PHP 8.2. There is so much low level bit twiddling going on in the code I don't feel like doing this myself unless I absolutely have too. If it comes to that I will make a pull request.

Thanks.

@JungleGenius
Copy link
Author

Update: Turns out the changes in this old un-merged pull request fixes the issues on PHP 8.2
https://github.com/dusterio/hlsinjector/pull/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant