Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Bookmarks deleted after close / re-open and adding a new one or layer switch #15

Closed
wowcut opened this issue Dec 14, 2018 · 3 comments
Assignees
Labels

Comments

@wowcut
Copy link

wowcut commented Dec 14, 2018

1. Summary

After closing and then re-opening Sublime Text all bookmarks disappear when adding a new bookmark (with F11). Also swapping the layers destroys all current bookmarks. This pnly seems to happen after a close/open cycle.

2. Expected behavior

Not deleting all existing bookmarks when adding a new one.

3. Actual behavior

I can not see bookmarks after file re-opening and adding a new bookmark.

4. Settings

My User\BetterBookmarks.sublime-settings file

{
	"layer_icons": {
		// This one is the default Sublime bookmark
		"bookmarks": {"icon": "bookmark", "scope": "string"},
		"functions": {"icon": "Packages/Better Bookmarks/icons/function.png", "scope": "comment"},
		"todos": {"icon": "Packages/Better Bookmarks/icons/todo.png", "scope": "comment"},
	}
}

4. Steps to reproduce

I install BetterBookmarks → I run command better_bookmarks_mark_line multiple times → I close file → I re-open file → I can see my bookmarks → I press F11 → all old bookmarks are gone.

5. Environment

Operating system and version:
Ubuntu 16.04
Sublime Text:
Build 3176

Thanks.

Originally posted by @Kristinita in #3 (comment)

@wowcut wowcut changed the title ### 1. Summary All Bookmarks deleted after close / re-open and adding a new one or layer switch Dec 14, 2018
@dusk125 dusk125 self-assigned this Dec 14, 2018
@dusk125 dusk125 added the bug label Dec 14, 2018
@dusk125
Copy link
Owner

dusk125 commented Dec 17, 2018

Thank you for the bug report, your issue is explained by this and should be fixed in the next version (v1.2.0).

@wowcut
Copy link
Author

wowcut commented Dec 19, 2018

Than you very much for your efforts! I am happy to finally have persistent bookmarks with sublime! The other features I like, too! Nice holidays!

@dusk125
Copy link
Owner

dusk125 commented Dec 22, 2018

v1.2.0 has been released and your problem should resolve once Package Control sees the new release. Happy Holidays!

@dusk125 dusk125 closed this as completed Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants