Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Public Inputs inside of the Composer on a sparse way #427

Closed
CPerezz opened this issue Mar 3, 2021 · 0 comments · Fixed by #423
Closed

Store Public Inputs inside of the Composer on a sparse way #427

CPerezz opened this issue Mar 3, 2021 · 0 comments · Fixed by #423
Assignees
Labels
team:Core Low Level Core Development Team (Rust)

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Mar 3, 2021

Instead of storing the dense vector that contains the public inputs that are also not being used, we should optimize the storage and try to avoid storing PublicInputs that are not being used inside of the composer.

Also on this way this could be the PI manager that the Circuit trait needs to improve the API and stop requiring the managing of the PI externally

@CPerezz CPerezz added the team:Core Low Level Core Development Team (Rust) label Mar 3, 2021
@CPerezz CPerezz self-assigned this Mar 3, 2021
@ZER0 ZER0 closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:Core Low Level Core Development Team (Rust)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants