Improve Circuit trait API and usability #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API was not flexible enough and it was forcing us to repeat a lot of code. - Trait now comes with build_pi, gen_proof, compile & verify_proof fn's already implemented. - It forces the user to implement the getters and setters for the PI vector storage. - It carries the circuit size already hardcored in it. We've also defined the method pos() for PublicInput in order to get quick access to them.
CPerezz
added
API-design
area:cryptography
CPerezz
force-pushed
the
circuit_api_refactor
branch
from
d2b41e0 to
1db9fde
Compare
jules
approved these changes
Oct 5, 2020
LukePearson1
reviewed
Oct 5, 2020
| @@ -34,34 +34,99 @@ impl PublicInput { | |||
| PublicInput::AffinePoint(point, _, _) => vec![point.get_x(), point.get_y()], | |||
| } | |||
| } | |||
|
|
|||
| /// Returns the positions that of a PublicInput struct | |||
There was a problem hiding this comment.
'That' left in mistakenly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API was not flexible enough and it was forcing us
to repeat a lot of code.
fn's already implemented.
vector storage.
We've also defined the method pos() for PublicInput in order to get
quick access to them.