Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Q] invoke dmenu revers order #1375

Closed
biopsin opened this issue Aug 27, 2024 · 9 comments · Fixed by #1394
Closed

[Q] invoke dmenu revers order #1375

biopsin opened this issue Aug 27, 2024 · 9 comments · Fixed by #1394

Comments

@biopsin
Copy link

biopsin commented Aug 27, 2024

2024-08-27-195254_3840x2160_scrot

Issue description

Hi, i need to revers the order dmenu outputs open notifications, the order in picture is "dmenu top" = "bottom notification" I would like to align it equal top to bottom?

Installation info

  • Version: 1.11
  • Install type: pkg
  • Window manager / Desktop environment: cwm
  • Distro: void
Minimal dunstrc
dmenu = /usr/local/bin/dmenu

#####dmenu bin
/usr/bin/dmenu -i -l 9 -x 1560 -w 720 -fn "Dejavu Sans:style=Book:pixelsize=16" \
	-nb "#FDF6E3" -nf "#555555" -sb "#657B83" -sf "#FFFFFF"
@bynect
Copy link
Member

bynect commented Aug 28, 2024

could it be that dmenu automatically orders entry by alphabetical order?

@biopsin
Copy link
Author

biopsin commented Aug 28, 2024

no the dmenu entries are ordered but in reverse order, however I will test with different priority tho.
Maybe your right its alphabetical but bottom to top in dmenu.

Yes dmenu_output is ordered alphabetical but thats fine as are the notifications (at least locally), so they both align, but one is in a revers order. The first dmenu_line should trigger first/top notification and so on as its intuitive at least to me to match a selected line with a spesific notification, if it makes sense?

@bynect
Copy link
Member

bynect commented Sep 3, 2024

I'm looking at this. could it be that you are using a particular notification ordering? or are you using the default one (last arrived at the top)?

also what did you do to open that notification menu? exact command

@biopsin
Copy link
Author

biopsin commented Sep 4, 2024

Yes default; last is top. Default binary location as in dunstrc but its a symlink to local/bin with extra dmenu config settings, nothing that would order on a custom level.
I guess it would also make sense to order/group in a mixed action nonaction condition all action notifications are stacked first/above all nonaction notifications.

@bynect
Copy link
Member

bynect commented Sep 8, 2024

what did you do to pop up that menu exactly?

@biopsin
Copy link
Author

biopsin commented Sep 9, 2024

bind-key 4M-space - "dunstctl context" or is there something else you are thinking of?

@bynect
Copy link
Member

bynect commented Sep 9, 2024

just wanted to be sure. I think the problem lies in this function here

static GList *get_actionable_notifications(void)

I will try to fix the order in some time

@bynect
Copy link
Member

bynect commented Nov 4, 2024

Hello, I successfully reproduced this problem and it turns out it was just a linked list being reversed.

@biopsin
Copy link
Author

biopsin commented Nov 4, 2024

@bynect Hi, thank you for looking into it, will test the patch later today both for vertical and horisontal dmenu context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants