T 16269 possible fix #1530
Merged
T 16269 possible fix #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow run id 3014282565 approved. |
|
Looks good to me, thanks again @0xRobin ! |
soispoke
approved these changes
Sep 8, 2022
soispoke
added a commit
that referenced
this pull request
Sep 8, 2022
* opposite amounts and incremental filters * remove wallet address from tests erc721 * fix send and receive, amount signs * T 16269 possible fix (#1530) * fix ERC721 balances * revert column refs in schemas Co-authored-by: 0xRob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief comments on the purpose of your changes:
Proposed changes for PR #1525
Possible fix for Issue #1524
We should probably also check erc1155 for correctness once this is solved.