Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin list all episodes/seasons for tv shows api request never ending and large data #103

Closed
camelCaseD opened this issue Dec 1, 2015 · 6 comments
Labels

Comments

@camelCaseD
Copy link

See below:

streamaadmin

It kept climbing up to 200mb before I left the page and cancelled the request

@dularion
Copy link
Member

dularion commented Dec 1, 2015

Wow .. that looks pretty bad! how many episodes do you have for that show? It shouldnt be 200mb at least.. I've looked into performance there already, and I will do more, but that seems more like a bug than anything else. Does this happen with any other show? Is there anything specific for that show that is worth mentioning and might bring me closer to a bugfix?

@dularion dularion added the Bug label Dec 1, 2015
@camelCaseD
Copy link
Author

The show has 220 episodes uploaded and about 4 seasons.

@camelCaseD
Copy link
Author

I think the issue is that each episode that is returned has a "nextEpsiode" property which continues to chain down through every episode until the last one in the series. Which is just excess data and only needs to show the direct next episode not two, five, or twenty down the chain. Or else episode one will chain all the way down to 220 then the second one will be 219 episodes long and etc.

@camelCaseD
Copy link
Author

I believe this line of code is the culprit. This line needs to somehow limit the number of results returned to 1. I don't know any groovy myself or else I would have created a PR.

@dularion
Copy link
Member

dularion commented Dec 5, 2015

Should be fixed! please let me know

@camelCaseD
Copy link
Author

Yes that fixed it, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants