Instant search suggestions #48
Conversation
| @@ -36,7 +36,7 @@ | |||
| "favicon_url": "https://duckduckgo.com/favicon.ico", | |||
| "is_default": true, | |||
| "keyword": "duckduckgo.com", | |||
| "name": "DuckDuckGo Search", | |||
There was a problem hiding this comment.
This was redundant as Chrome will automatically append the word "Search" to the search provider's name, resulting in labels like "DuckDuckGo Search Search" in the omnibox.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "DuckDuckGo for Chrome", | |||
There was a problem hiding this comment.
This change is optional, but I recommend it because once entering "extension mode" (d + Space in the omnibox), this setting specifies the label that is shown in the omnibox before every search query, and it should be both as succinct and as semantic as possible.
|
@gaborluk |
|
@jdorweiler, thanks for the heads-up. As for the changes, if you need a helping hand, let me know. |
This changeset implements instant search suggestions per #32.
To receive suggestions, the user has to explicitly type the extension's keyword first (currently
d), and hit space. If thedkeyword is already defined in the browser as another search provider's keyword, the omnibox will not enter "extension mode". The implementation emulates Chrome's inverse suggestion highlighting style (the suggested part is bold), and handles !bangs.It would be desirable for the omnibox to display instant suggestions as soon as the user types something into the naked omnibox, but currently this is not doable. While the
manifest.jsondocumentation specifies an optionalinstant_urlkey for thesearch_provider, it is not documented how this should work or what format Chrome expects the suggestions to arrive in, and is probably not even implemented, much like the relatedsearch_url_post_params.