Skip to content
This repository has been archived by the owner on Jan 10, 2019. It is now read-only.

Add node_modules in .gitignore and add package-lock.json #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add node_modules in .gitignore and add package-lock.json #200

wants to merge 1 commit into from

Conversation

lunaticmonk
Copy link

Description:

Fixes #199

Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@lunaticmonk
Copy link
Author

Please review the pull request.

@lunaticmonk
Copy link
Author

@bsstoner Please review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lunaticmonk