This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
RE: ARCHITECTURE #148
Merged
RE: ARCHITECTURE #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duck8823
added
enhancement
Pull Request Test Coverage Report for Build 882
💛 - Coveralls |
duck8823
force-pushed
the
rearchitecture
branch
from
56542ff to
f4429f7
Compare
duck8823
force-pushed
the
rearchitecture
branch
from
f4429f7 to
53db3bb
Compare
golangcibot
reviewed
Nov 28, 2018
application/service/runner/helper.go
Outdated
| } | ||
|
|
||
| // runtimeOptions parses a config.yml and returns a docker runtime options | ||
| func runtimeOptions(workDir string) (docker.RuntimeOptions, error) { |
There was a problem hiding this comment.
runtimeOptions is unused (from deadcode)
golangcibot
reviewed
Dec 1, 2018
domain/model/docker/log.go
Outdated
| s := &struct { | ||
| Stream string `json:"stream"` | ||
| }{} | ||
| json.NewDecoder(bytes.NewReader(line)).Decode(s) |
There was a problem hiding this comment.
Error return value of (*encoding/json.Decoder).Decode is not checked (from errcheck)
domain/model/docker/log.go
Outdated
|
|
||
| // prevent to CR | ||
| progress := bytes.Split(messages, []byte{'\r'}) | ||
| return &job.LogLine{Timestamp: now(), Message: string(progress[0])}, readErr |
There was a problem hiding this comment.
the surrounding loop is unconditionally terminated (from megacheck)
golangcibot
reviewed
Dec 1, 2018
| if err != nil { | ||
| return errors.WithStack(err) | ||
| } | ||
| defer cleanup() |
There was a problem hiding this comment.
Error return value of cleanup is not checked (from errcheck)
golangcibot
reviewed
Dec 2, 2018
domain/model/docker/log.go
Outdated
|
|
||
| // prevent to CR | ||
| progress := bytes.Split(messages, []byte{'\r'}) | ||
| return &LogLine{Timestamp: now(), Message: string(progress[0])}, readErr |
There was a problem hiding this comment.
the surrounding loop is unconditionally terminated (from megacheck)
|
ci build |
duck8823
force-pushed
the
rearchitecture
branch
from
9fbed8c to
8580b25
Compare
|
ci test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #145