From 3f824542e0f0459718151ffbde3a1db2db145b3f Mon Sep 17 00:00:00 2001
From: Adrian Moennich <adrian.moennich@cern.ch>
Date: Tue, 5 Mar 2024 20:17:07 +0100
Subject: [PATCH] Minor survey UX improvements

- submit button label in email dialog
- no period at end of email subject
- centered lock icon
- correct button margin
---
 .../modules/events/surveys/controllers/management/survey.py   | 2 +-
 .../events/surveys/templates/emails/survey_link_email.html    | 2 +-
 .../modules/events/surveys/templates/management/survey.html   | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/indico/modules/events/surveys/controllers/management/survey.py b/indico/modules/events/surveys/controllers/management/survey.py
index c937081d77c..6608beb9f07 100644
--- a/indico/modules/events/surveys/controllers/management/survey.py
+++ b/indico/modules/events/surveys/controllers/management/survey.py
@@ -150,7 +150,7 @@ def _process(self):
             num = len(form.recipients.data)
             flash(ngettext('Your email has been sent.', '{} emails have been sent.', num).format(num))
             return jsonify_data(flash=True)
-        return jsonify_form(form)
+        return jsonify_form(form, submit=_('Send'))
 
     def _send_emails(self, form, recipients):
         for recipient in recipients:
diff --git a/indico/modules/events/surveys/templates/emails/survey_link_email.html b/indico/modules/events/surveys/templates/emails/survey_link_email.html
index d1705a1110b..e7a03e6d695 100644
--- a/indico/modules/events/surveys/templates/emails/survey_link_email.html
+++ b/indico/modules/events/surveys/templates/emails/survey_link_email.html
@@ -1,5 +1,5 @@
 {% macro get_subject() -%}
-    Survey "{survey_title}" for event "{event_title}" has started.
+    Survey "{survey_title}" for event "{event_title}" has started
 {%- endmacro %}
 
 {% macro get_html_body() -%}
diff --git a/indico/modules/events/surveys/templates/management/survey.html b/indico/modules/events/surveys/templates/management/survey.html
index 0dc49612a45..48481af9748 100644
--- a/indico/modules/events/surveys/templates/management/survey.html
+++ b/indico/modules/events/surveys/templates/management/survey.html
@@ -6,7 +6,7 @@
     {% if survey.private and survey.state.name in ('active_and_clean', 'active_and_answered') %}
         <div class="action-box highlight">
             <div class="section">
-                <div class="icon icon-lock"></div>
+                <div class="icon icon-lock-center"></div>
                 <div class="text">
                     <div class="label">
                         {%- trans %}The survey is private{% endtrans -%}
@@ -24,7 +24,7 @@
                     {%- endtrans %}
                 </div>
                 <div class="toolbar">
-                    <button class="i-button icon-mail right highlight js-requires-selected-row send-mails-btn"
+                    <button class="i-button icon-mail highlight js-requires-selected-row send-mails-btn"
                             data-href="{{ url_for('surveys.send_links', survey) }}"
                             data-title="{% trans %}Send survey links{% endtrans %}"
                             data-method="POST"