Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Gridster instead of jquery-sortable #87

Open
sclausen opened this issue Sep 17, 2014 · 11 comments
Open

Angular Gridster instead of jquery-sortable #87

sclausen opened this issue Sep 17, 2014 · 11 comments

Comments

@sclausen
Copy link

For a more consistent layout I propose angular-gridster as a replacement for angular-ui-sortable

@andyperlitch
Copy link
Collaborator

@sclausen sorry for the delayed response. We are open to switching angular-gridster (or maybe making it a configuration option / optional dependency?). Can you make a pull request?

@awashbrook
Copy link
Contributor

We would also be interested

@andyperlitch
Copy link
Collaborator

My only beef with gridster is that the height of the widgets cannot be determined by the height of the content. This means that every widget will need to be height-aware, or have something like overflow:auto in its css. Thoughts on this anyone?

@awashbrook
Copy link
Contributor

...finishing my thought: we would be interested in minimising the dependencies of Malhar dashboard framework, leaving decisions on heavy libraries like jquery-ui to webapps.

ManifestWebDesign/angular-gridster#2

From the above looks like gridster finally have their own DnD implementation and no longer require jquery-ui.

Can you consider ditching angular-ui-sortable and jquery-ui entirely?

@zhx828
Copy link

zhx828 commented Jan 20, 2015

Agree with above. Would suggest add layout control by users. Packery also a good choice. Glad to help if needed to push some changes.

@andyperlitch andyperlitch added this to the v1.0.0 milestone Feb 1, 2015
@andyperlitch andyperlitch changed the title Angular Grister instead of jquery-sortable Angular Gridster instead of jquery-sortable Feb 10, 2015
@andyperlitch
Copy link
Collaborator

I'm going to give ng-sortable a try for v1.0.0... it looks like it has matured a fair amount in the last six months.

@sclausen
Copy link
Author

ng-sortable hase the same problem as angular-ui-sortable. if the cells are not equal sizes the layout is messed up. for example angular-gridster has relative cell-sizes which makes the layout more consistent.

@andyperlitch
Copy link
Collaborator

Yeah, I gave it a shot and it was not too pretty... will give gridster another look. My beef with gridster is that it has fixed height for all elements :-/ this can be pretty hard to deal with for certain widget content.

@andyperlitch andyperlitch removed this from the v1.0.0 milestone Mar 13, 2015
@andyperlitch
Copy link
Collaborator

removing this from the 1.0.0 milestone as this is probably achievable using a custom dashboard template. If someone else wants to add this option, i am open to PRs.

@artoliukkonen
Copy link

We choose to switch to Gridster in our project, so I forked this repo and made the changes. It's working pretty fine I'd say. https://github.com/SC5/malhar-angular-dashboard

Disclaimer: haven't touched to tests (possibly broken), haven't touched to demo (completely broken), switched to Foundation instead of Bootstrap (just because we're using it in our project). In case someone chooses to try our version, feel free to contact us for guidance.

@rihabesx
Copy link

Hi artoliukkonen!
I am interested in the gridster fork but my project uses bootstrap. Could you please tell me what changes are required to make it work as gridster/bootstrap instead of gridster/foundation.

Also what is the possibility of getting the demo application to work. This is simplified version and will help a lot. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants