Skip to content

Commit

Permalink
clarify consistency requirements of GetActionResult (#79)
Browse files Browse the repository at this point in the history
- move the statement from the service documentation to the call.
- add a section about extending TTLs

related discussions:
- https://groups.google.com/d/msg/remote-execution-apis/zmcEV8kubRc/5PPcHOVZAgAJ
- bazelbuild/bazel#6862
  • Loading branch information
dtorres314 committed May 22, 2019
1 parent 6e5b438 commit 76d44d0
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions build/bazel/remote/execution/v2/remote_execution.proto
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,7 @@ service Execution {
//
// The lifetime of entries in the action cache is implementation-specific, but
// the server SHOULD assume that more recently used entries are more likely to
// be used again. Additionally, action cache implementations SHOULD ensure that
// any blobs referenced in the
// [ContentAddressableStorage][build.bazel.remote.execution.v2.ContentAddressableStorage]
// are still valid when returning a result.
// be used again.
//
// As with other services in the Remote Execution API, any call may return an
// error with a [RetryInfo][google.rpc.RetryInfo] error detail providing
Expand All @@ -140,6 +137,13 @@ service Execution {
service ActionCache {
// Retrieve a cached execution result.
//
// Implementations SHOULD ensure that any blobs referenced from the
// [ContentAddressableStorage][build.bazel.remote.execution.v2.ContentAddressableStorage]
// are available at the time of returning the
// [ActionResult][build.bazel.remote.execution.v2.ActionResult] and will be
// for some period of time afterwards. The TTLs of the referenced blobs SHOULD be increased
// if necessary and applicable.
//
// Errors:
//
// * `NOT_FOUND`: The requested `ActionResult` is not in the cache.
Expand Down

0 comments on commit 76d44d0

Please sign in to comment.