Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't run build probes in rustc bootstrap #248

Merged
merged 1 commit into from
Aug 15, 2023
Merged

don't run build probes in rustc bootstrap #248

merged 1 commit into from
Aug 15, 2023

Conversation

RalfJung
Copy link
Contributor

@dtolnay said

I would be open to a different thiserror PR that does not rewrite any of the macro, but just changes build.rs to detect when it is being built as a dependency of rustc (hopefully there is an environment variable or cfg for this) and permanently disables unstable functionality in that case.

This PR implements that.

@RalfJung RalfJung mentioned this pull request Aug 15, 2023
Merged
dtolnay
dtolnay approved these changes Aug 15, 2023
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 1f02cdf into dtolnay:master Aug 15, 2023
@dtolnay
Copy link
Owner

dtolnay commented Aug 15, 2023

Published in thiserror 1.0.46.

@RalfJung RalfJung mentioned this pull request Aug 16, 2023
Closed
@lqd lqd mentioned this pull request Aug 17, 2023
Merged
cuviper added a commit to cuviper/rust that referenced this pull request Aug 17, 2023
@cuviper
Rollup merge of rust-lang#114944 - lqd:fix-thiserror, r=RalfJung
df877c0 
update `thiserror` to version >= 1.0.46

1.0.46 version is the one with [the workaround](dtolnay/thiserror#248) for rust-lang#114839. I'm also encountering this issue, so let's update the dependency so that everyone doesn't have to `./x clean`.

Fixes rust-lang#114839.

r? `@RalfJung`
This was referenced Dec 25, 2023
Merged
Merged
@dtolnay dtolnay mentioned this pull request Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RalfJung @dtolnay