Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.52 update causing constant recompilation #270

Closed
Turbo87 opened this issue Dec 28, 2023 · 6 comments
Closed

v1.0.52 update causing constant recompilation #270

Turbo87 opened this issue Dec 28, 2023 · 6 comments

Comments

@Turbo87
Copy link

Turbo87 commented Dec 28, 2023

After merging rust-lang/crates.io#7808 I noticed that some dependencies started to recompile for every build. I just ran a git bisect session and could reproduce the issue:

Bildschirmfoto 2023-12-28 um 11 59 54

I assume this is most likely related to:

@Turbo87
Copy link
Author

Turbo87 commented Dec 28, 2023

It looks like anyhow v1.0.77 is causing similar issues

@dtolnay
Copy link
Owner

dtolnay commented Dec 28, 2023

How can I reproduce this? I ran cargo check --workspace in rust-lang/crates.io twice and nothing got recompiled, at rust-lang/crates.io@95236c5 which is before the 2 revert commits.

@Turbo87
Copy link
Author

Turbo87 commented Dec 28, 2023

hmm, I noticed it while running tests from within IntelliJ. I'll try and reproduce it on the command line once I'm back on the computer tomorrow.

@Turbo87
Copy link
Author

Turbo87 commented Dec 29, 2023

looks like IntelliJ is more or less at fault here... when running the test suite inside of IntelliJ it is first compiling the test code via:

cargo test --color=always --no-run --package crates_io --lib rate_limiter::tests

and then running the tests with:

cargo test --color=always --package crates_io --lib rate_limiter::tests --no-fail-fast -- --format=json -Z unstable-options --show-output

if I try to run the latter on the CLI outside of IntelliJ I get:

error: the option `Z` is only accepted on the nightly compiler
error: test failed, to rerun pass `-p crates_io --lib`
error: 1 target failed:
    `-p crates_io --lib`

so I guess IntelliJ might be using RUSTC_BOOTSTRAP to enable usage of -Z unstable-options on the stable compiler 🙈

@Turbo87
Copy link
Author

Turbo87 commented Dec 29, 2023

@dtolnay
Copy link
Owner

dtolnay commented Dec 29, 2023

Good catch. I commented on the RustRover issue tracker with my suggested fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants