Fix fallback fmt expression parser hang

dtolnay · Nov 10, 2024 · 591a44d · 591a44d
1 parent 5b36e37
commit 591a44d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/impl/src/fmt.rs b/impl/src/fmt.rs
@@ -193,6 +193,8 @@ fn fallback_explicit_named_args(input: ParseStream) -> Result<FmtArguments> {
             let ident = input.call(Ident::parse_any)?;
             input.parse::<Token![=]>()?;
             args.named.insert(ident);
+        } else {
+            input.parse::<TokenTree>()?;
         }
     }
 

diff --git a/tests/ui/expression-fallback.stderr b/tests/ui/expression-fallback.stderr
@@ -0,0 +1,19 @@
+error: expected `,`, found `.`
+ --> tests/ui/expression-fallback.rs:4:11
+  |
+4 | #[error("".yellow)]
+  |           ^ expected `,`
+
+error: argument never used
+ --> tests/ui/expression-fallback.rs:4:12
+  |
+4 | #[error("".yellow)]
+  |         -- ^^^^^^ argument never used
+  |         |
+  |         formatting specifier missing
+
+error[E0425]: cannot find value `yellow` in this scope
+ --> tests/ui/expression-fallback.rs:4:12
+  |
+4 | #[error("".yellow)]
+  |            ^^^^^^ not found in this scope