-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate WildcardVersion::Major? #150
Comments
This is a good question! I'm not sure. |
For my specific problem, introducing a function like |
I've accepted the underlying PR in semver-parser, so we can do this here too. |
This is fixed in 1.0.0. The |
Hey,
I'm currently trying to do a comparison for when a
VersionReq
is a full wildcard:*
.For all intents and purposes, the following states of
VersionReq
appears to be equivalent:predicates
is empty, causing theall
check to returntrue
.op
isOp::Wildcard(WildcardVersion::Major)
.Both of these cases appears to match any version. Both of them are
fmt::Display
:ed in a way so that they show*
.I would like to discuss if we could either have
VersionReq::any()
return the same as when*
is parsed (singleWildcardVersion::Major
predicate) to make comparisons viable. Or to completely deprecate the use ofWilcardVersion::Major
since its functionality is equivalent to an empty set of predicates.The text was updated successfully, but these errors were encountered: